fix: refine agent image attachments and restore Korean filenames

This commit is contained in:
2026-10-19 14:47:21 +09:00
parent 234c9ad467
commit 4321d944b5
8 changed files with 150 additions and 12 deletions
+71 -1
View File
@@ -3,6 +3,8 @@ const assert = require('node:assert/strict')
const fs = require('node:fs')
const vm = require('node:vm')
const ts = require('typescript')
const React = require('react')
const { renderToStaticMarkup } = require('react-dom/server')
function setup() {
const api = {}
@@ -18,7 +20,7 @@ function setup() {
},
URL: { createObjectURL: () => `blob:fixture-${++count}`, revokeObjectURL: url => revoked.push(url) }
})
return { read: (files, existing = []) => api.readChatAttachments(files, existing, { imagesEnabled: true }), revoked }
return { api, read: (files, existing = []) => api.readChatAttachments(files, existing, { imagesEnabled: true }), revoked }
}
const image = (extra = {}) => ({ name: 'screen.png', size: 100, ...extra })
@@ -46,3 +48,71 @@ test('a mixed batch failure revokes only newly created image previews', async ()
assert.deepEqual(h.revoked, ['blob:fixture-2'])
assert.equal(existing[0].previewUrl, 'blob:fixture-1')
})
test('restores cached multipart filenames while preserving valid Unicode and Latin-1 names', () => {
const { api } = setup()
const name = '스크린샷 2026-10-19 14-30-45.png'
assert.equal(api.displayAttachmentName(Buffer.from(name).toString('latin1')), name)
for (const value of [name, 'screen.png', 'caf\u00e9.png', '\uD83D\uDCF7.png']) assert.equal(api.displayAttachmentName(value), value)
})
function previewHarness() {
const { api } = setup()
const exports = {}
let preview = null
vm.runInNewContext(ts.transpileModule(fs.readFileSync(require.resolve('../src/renderer/src/components/ChatImageAttachments.tsx'), 'utf8'), {
compilerOptions: { module: ts.ModuleKind.CommonJS, target: ts.ScriptTarget.ES2022, jsx: ts.JsxEmit.ReactJSX }
}).outputText, {
exports,
document: { body: {} },
require(name) {
if (name === 'react') return { ...React, useEffect() {}, useRef: () => ({ current: null }), useState: () => [preview, value => { preview = value }] }
if (name === 'react-dom') return { createPortal: child => child }
if (name === '../i18n') return { t: key => key, useLocaleRender() {} }
if (name === './chatAttachments') return api
return require(name)
}
})
const find = (node, predicate) => {
if (!React.isValidElement(node)) return null
if (predicate(node)) return node
return React.Children.toArray(node.props.children).map(child => find(child, predicate)).find(Boolean)
}
return { render: props => exports.ChatImageAttachments(props), find }
}
for (const dark of [true, false]) {
test(`draft combines thumbnail, truncated filename and removal in one bounded item (${dark ? 'dark' : 'light'})`, () => {
const h = previewHarness()
const name = '스크린샷-긴파일이름-'.repeat(12) + '.png'
let removed
const props = { images: [{ name, url: 'blob:fixture' }], dark, onRemove: image => { removed = image.url } }
const tree = h.render(props)
const item = h.find(tree, node => node.props['data-chat-image-draft'])
assert.ok(item)
assert.match(item.props.className, /w-56.*max-w-full/)
assert.ok(h.find(item, node => node.type === 'img'))
const label = h.find(item, node => node.type === 'span')
assert.equal(label.props.children, name)
assert.match(label.props.className, /truncate/)
const zoom = h.find(item, node => node.type === 'button' && node.props.title === name)
assert.equal(zoom.props.title, name)
h.find(item, node => node.type === 'button' && node.props['aria-label'] === `첨부 제거: ${name}`).props.onClick()
assert.equal(removed, 'blob:fixture')
const busyItem = h.find(h.render({ ...props, removeDisabled: true }), node => node.props['data-chat-image-draft'])
assert.equal(h.find(busyItem, node => node.type === 'button' && node.props['aria-label'] === `첨부 제거: ${name}`).props.disabled, true)
})
}
test('cached garbled names are restored in the thumbnail label and enlarged dialog', () => {
const h = previewHarness()
const name = '스크린샷 2026-10-19 14-30-45.png'
const props = { images: [{ name: Buffer.from(name).toString('latin1'), url: 'https://files.test/image.png' }], variant: 'sent' }
const tree = h.render(props)
assert.equal(h.find(tree, node => node.type === 'button').props.title, name)
assert.equal(h.find(tree, node => node.props['data-chat-image-draft']), undefined)
h.find(tree, node => node.type === 'button').props.onClick()
const html = renderToStaticMarkup(h.render(props))
assert.match(html, /<dialog[^>]*aria-label="스크린샷 2026-10-19 14-30-45.png"/)
assert.ok(html.includes(`>${name}</span>`))
})